OSDN Git Service

thunderbolt: Right shifting to zero bug in tbnet_handle_packet()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 17 Oct 2017 12:33:01 +0000 (15:33 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 19 Oct 2017 12:04:32 +0000 (13:04 +0100)
commitfa31f0c98d64212b2b2b4a1e6d887208b6acb2d9
treec859f811605bde3ceb13e06885d12845b0f39b9e
parent9a03c3d398c17eadfc5bc470c1084beb71c088f1
thunderbolt: Right shifting to zero bug in tbnet_handle_packet()

There is a problem when we do:

sequence = pkg->hdr.length_sn & TBIP_HDR_SN_MASK;
sequence >>= TBIP_HDR_SN_SHIFT;

TBIP_HDR_SN_SHIFT is 27, and right shifting a u8 27 bits is always
going to result in zero.  The fix is to declare these variables as u32.

Fixes: e69b6c02b4c3 ("net: Add support for networking over Thunderbolt cable")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Yehezkel Bernat <yehezkel.bernat@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/thunderbolt.c