OSDN Git Service

libcacard/vreader: Drop broken recovery from failed assertion
authorMarkus Armbruster <armbru@redhat.com>
Fri, 23 May 2014 11:24:35 +0000 (13:24 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Fri, 23 May 2014 20:46:01 +0000 (00:46 +0400)
commitfa5912a17b51b807c4ec78a4aa914891c7770781
tree177da6ded0c502077dc15a98ed653993532bc8bd
parent124fe7fb1b7a1db8cb2ebb9edae84716ffaf37ce
libcacard/vreader: Drop broken recovery from failed assertion

We suppress some code when we got unexpected status and assertion
checking is off:

     assert(card_status == VCARD_DONE);
     if (card_status == VCARD_DONE) {
         int size = MIN(*receive_buf_len, response->b_total_len);
         memcpy(receive_buf, response->b_data, size);
         *receive_buf_len = size;
    }

Such "recovery" is of dubious value even when it works.  This one
doesn't: it fails to assign to receive_buf[] and *receive_buf_len,
which the callers expect.

Make the code unconditional.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alon Levy <alevy@redhat.com>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
libcacard/vreader.c