OSDN Git Service

module/decompress: Fix error checking on zstd decompression
authorLucas De Marchi <lucas.demarchi@intel.com>
Thu, 1 Jun 2023 21:23:31 +0000 (14:23 -0700)
committerLuis Chamberlain <mcgrof@kernel.org>
Thu, 1 Jun 2023 21:36:46 +0000 (14:36 -0700)
commitfadb74f9f2f609238070c7ca1b04933dc9400e4a
tree9f93bf862f5c7a460cc947b1e0dba20f45a70603
parentdb3e33dd8bd956f165436afdbdbf1c653fb3c8e6
module/decompress: Fix error checking on zstd decompression

While implementing support for in-kernel decompression in kmod,
finit_module() was returning a very suspicious value:

finit_module(3, "", MODULE_INIT_COMPRESSED_FILE) = 18446744072717407296

It turns out the check for module_get_next_page() failing is wrong,
and hence the decompression was not really taking place. Invert
the condition to fix it.

Fixes: 169a58ad824d ("module/decompress: Support zstd in-kernel decompression")
Cc: stable@kernel.org
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
kernel/module/decompress.c