OSDN Git Service

bnxt_en: Fix AER recovery.
authorVasundhara Volam <vasundhara-v.volam@broadcom.com>
Sun, 27 Dec 2020 19:18:17 +0000 (14:18 -0500)
committerJakub Kicinski <kuba@kernel.org>
Mon, 28 Dec 2020 22:10:52 +0000 (14:10 -0800)
commitfb1e6e562b37b39adfe251919c9abfdb3e01f921
tree9c5ed4d9768fab231f42e4b6a0b33bdaa4fcbe8e
parent74f88c1676aa0b4518549c5a846875a6102ab540
bnxt_en: Fix AER recovery.

A recent change skips sending firmware messages to the firmware when
pci_channel_offline() is true during fatal AER error.  To make this
complete, we need to move the re-initialization sequence to
bnxt_io_resume(), otherwise the firmware messages to re-initialize
will all be skipped.  In any case, it is more correct to re-initialize
in bnxt_io_resume().

Also, fix the reverse x-mas tree format when defining variables
in bnxt_io_slot_reset().

Fixes: b340dc680ed4 ("bnxt_en: Avoid sending firmware messages when AER error is detected.")
Reviewed-by: Edwin Peer <edwin.peer@broadcom.com>
Signed-off-by: Vasundhara Volam <vasundhara-v.volam@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt.c