OSDN Git Service

ALSA: rawmidi: Fix missing input substream checks in compat ioctls
authorTakashi Iwai <tiwai@suse.de>
Thu, 19 Apr 2018 16:16:15 +0000 (18:16 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 24 Apr 2018 07:32:10 +0000 (09:32 +0200)
commitfc338748e3e7740113c1c26e2248d919dd8cc05c
tree35e6088d8ddf5dc6a4d632552a8fdadc5e8c6336
parent68fc6f74b516447bbbddde1b08437787d0063c6d
ALSA: rawmidi: Fix missing input substream checks in compat ioctls

commit 8a56ef4f3ffba9ebf4967b61ef600b0a7ba10f11 upstream.

Some rawmidi compat ioctls lack of the input substream checks
(although they do check only for rfile->output).  This many eventually
lead to an Oops as NULL substream is passed to the rawmidi core
functions.

Fix it by adding the proper checks before each function call.

The bug was spotted by syzkaller.

Reported-by: syzbot+f7a0348affc3b67bc617@syzkaller.appspotmail.com
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/core/rawmidi_compat.c