OSDN Git Service

hw/display/pxa2xx_lcd: Fix 16bpp+alpha and 18bpp+alpha palette formats
authorPeter Maydell <peter.maydell@linaro.org>
Tue, 27 May 2014 16:09:49 +0000 (17:09 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Tue, 27 May 2014 16:09:49 +0000 (17:09 +0100)
commitfc37b7a0b0cebe4118d172c4fceb0acc2fa25b4a
treee48d3ee6d6cdf8014656d35bf27f22d241483207
parent9ef137cad67bdfdf6adf80c91eea26209f4115ab
hw/display/pxa2xx_lcd: Fix 16bpp+alpha and 18bpp+alpha palette formats

The pxa2xx palette entry "16bpp plus transparency" format is
xxxxxxxTRRRRR000GGGGGG00BBBBB000, and "18bpp plus transparency" is
xxxxxxxTRRRRRR00GGGGGG00BBBBBB00.

Correct errors in the code for reading these and converting
them to the internal format. In particular, the buggy code
was attempting to mask out bit 24 of a uint16_t, which
Coverity spotted as an error.

Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 1400233901-31785-1-git-send-email-peter.maydell@linaro.org
hw/display/pxa2xx_lcd.c