OSDN Git Service

x86: Properly parenthesize cmpxchg() macro arguments
authorJan Beulich <JBeulich@suse.com>
Thu, 26 Jan 2012 15:47:37 +0000 (15:47 +0000)
committerIngo Molnar <mingo@elte.hu>
Thu, 26 Jan 2012 20:18:29 +0000 (21:18 +0100)
commitfc395b9291925b1880e0afc61274fe2f6ddc1269
tree45dc8b5453cb6d5c4db821d8dfa751b96fec93c3
parent5b68edc91cdc972c46f76f85eded7ffddc3ff5c2
x86: Properly parenthesize cmpxchg() macro arguments

Quite oddly, all of the arguments passed through from the top
level macros to the second level which didn't need parentheses
had them, while the only expression (involving a parameter)
needing them didn't.

Very recently I got bitten by the lack thereof when using
something like "array + index" for the first operand, with
"array" being an array more narrow than int.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/4F2183A9020000780006F3E6@nat28.tlf.novell.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/include/asm/cmpxchg.h