OSDN Git Service

ASoC: SOF: Intel: Do not (wrongly) assume positive return value in IMR path
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Wed, 27 Apr 2022 11:51:59 +0000 (14:51 +0300)
committerMark Brown <broonie@kernel.org>
Wed, 27 Apr 2022 13:15:29 +0000 (14:15 +0100)
commitfd2cea169c4bc01f88bca84e4f01df48901c4339
treef235218a64f409cc62ae493138518efe460d7a03
parentd879e9444634e3ef7cc5646fca0892c4f1483a8d
ASoC: SOF: Intel: Do not (wrongly) assume positive return value in IMR path

The cl_dsp_init() returns 0 on success or negative errno on error.
Replace the 'if (ret >= 0)' checks with correct 'if (!ret)` to check for
success.

Fixes: 2a68ff846164 ("ASoC: SOF: Intel: hda: Revisit IMR boot sequence")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20220427115159.26177-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/intel/hda-loader.c