OSDN Git Service

loader: fix close on uninitialized file descriptor value
authorLionel Landwerlin <lionel.g.landwerlin@intel.com>
Wed, 18 Dec 2019 15:48:26 +0000 (17:48 +0200)
committerDylan Baker <dylan@pnwbakers.com>
Tue, 7 Jan 2020 17:20:49 +0000 (09:20 -0800)
commitfe3c3f454c993616749f464e54bc0ff19da4814f
tree579e3a3ab6e112d28635918231659602b858bedd
parent99aed839e124689705b6582dbd51b53f1d098fda
loader: fix close on uninitialized file descriptor value

Using a drm syscall layer faking a kernel driver :

  ==581460== Conditional jump or move depends on uninitialised value(s)
  ==581460==    by 0x48A4C2B: close (drm-hooks.cpp:185)
  ==581460==    by 0x5A815F1: dri3_alloc_render_buffer (loader_dri3_helper.c:1469)
  ==581460==    by 0x5A82050: dri3_get_buffer (loader_dri3_helper.c:1827)
  ==581460==    by 0x5A82662: loader_dri3_get_buffers (loader_dri3_helper.c:2028)
  ==581460==    by 0x6C78109: intel_update_image_buffers (brw_context.c:1870)
  ==581460==    by 0x6C77805: intel_update_renderbuffers (brw_context.c:1499)
  ==581460==    by 0x6C7789D: intel_prepare_render (brw_context.c:1520)
  ==581460==    by 0x6C773D4: intelMakeCurrent (brw_context.c:1341)

Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 069fdd5f9fac ("egl/x11: Support DRI3 v1.1")
Reviewed-by: Eric Anholt <eric@anholt.net>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3152>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3152>
(cherry picked from commit fc2552b6445a1295c18acf8798411da85bbc5387)
src/loader/loader_dri3_helper.c