OSDN Git Service

net: phy: broadcom: Fix RGMII delays configuration for BCM54210E
authorFlorian Fainelli <f.fainelli@gmail.com>
Thu, 3 Oct 2019 18:43:51 +0000 (11:43 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 4 Oct 2019 21:12:48 +0000 (14:12 -0700)
commitfea7fda7f50a6059220f83251e70709e45cc8040
tree47660c85d3db6e8a80211ca0dc6b64f7788c286a
parent6d4e4ddc75ebd2849c57beeec6c6b07c2c0fbd18
net: phy: broadcom: Fix RGMII delays configuration for BCM54210E

Commit 0fc9ae107669 ("net: phy: broadcom: add support for
BCM54210E") added support for BCM54210E but also unconditionally cleared
the RXC to RXD skew and the TXD to TXC skew, thus only making
PHY_INTERFACE_MODE_RGMII a possible configuration. Use
bcm54xx_config_clock_delay() which correctly sets the registers
depending on the 4 possible PHY interface values that exist for RGMII.

Fixes: 0fc9ae107669 ("net: phy: broadcom: add support for BCM54210E")
Reported-by: Manasa Mudireddy <manasa.mudireddy@broadcom.com>
Reported-by: Ray Jui <ray.jui@broadcom.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/broadcom.c