OSDN Git Service

sfc: elide assignment of skb
authorEdward Cree <ecree@solarflare.com>
Tue, 18 Feb 2020 17:34:00 +0000 (17:34 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Feb 2020 20:40:49 +0000 (12:40 -0800)
Instead of assigning skb = segments before the loop, just pass
 segments directly as the first argument to skb_list_walk_safe().

Signed-off-by: Edward Cree <ecree@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/tx.c

index 04d7f41..696a77c 100644 (file)
@@ -287,9 +287,8 @@ static int efx_tx_tso_fallback(struct efx_tx_queue *tx_queue,
                return PTR_ERR(segments);
 
        dev_consume_skb_any(skb);
-       skb = segments;
 
-       skb_list_walk_safe(skb, skb, next) {
+       skb_list_walk_safe(segments, skb, next) {
                skb_mark_not_on_list(skb);
                efx_enqueue_skb(tx_queue, skb);
        }