OSDN Git Service

ASoC: Intel: cht_bsw_max98090: remove useless code, align with ChromeOS driver
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 5 Oct 2017 04:04:27 +0000 (23:04 -0500)
committerMark Brown <broonie@kernel.org>
Mon, 9 Oct 2017 09:15:43 +0000 (10:15 +0100)
Remove dead code which was missed in previous changes. This is not
visible with git diff but there is a test+return on the same condition
just above.

Also reuse local variable instead of fetching the jack information twice.

Tested on Acer R11 (cyan)

Fixes: 3bbda5a38601 ('ASoC: Intel: cht_bsw_max98090_ti: Fix jack initialization')
Cc: Thierry Escande <thierry.escande@collabora.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Acked-By: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/intel/boards/cht_bsw_max98090_ti.c

index 6519604..a23eba7 100644 (file)
@@ -219,10 +219,6 @@ static int cht_codec_init(struct snd_soc_pcm_runtime *runtime)
                return ret;
        }
 
-
-       if (ctx->ts3a227e_present)
-               snd_soc_jack_notifier_register(jack, &cht_jack_nb);
-
        ret = snd_soc_jack_add_gpiods(runtime->card->dev->parent, jack,
                                      ARRAY_SIZE(hs_jack_gpios),
                                      hs_jack_gpios);
@@ -323,7 +319,7 @@ static int cht_max98090_headset_init(struct snd_soc_component *component)
                return ret;
        }
 
-       return ts3a227e_enable_jack_detect(component, &ctx->jack);
+       return ts3a227e_enable_jack_detect(component, jack);
 }
 
 static const struct snd_soc_ops cht_aif1_ops = {