OSDN Git Service

ethernet: mvneta: Use PHY status standard message
authorEzequiel Garcia <ezequiel.garcia@free-electrons.com>
Fri, 31 Oct 2014 15:57:20 +0000 (12:57 -0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 31 Oct 2014 20:11:23 +0000 (16:11 -0400)
Use phy_print_status() to report a change in the PHY status.
The current message is not verbose enough, so this commit improves
it by using the generic status message.

After this change, the kernel reports PHY status down and up events as:

mvneta f1070000.ethernet eth0: Link is Down
mvneta f1070000.ethernet eth0: Link is Up - 1Gbps/Full - flow control rx/tx

Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvneta.c

index ade067d..ccc3ce2 100644 (file)
@@ -2558,11 +2558,10 @@ static void mvneta_adjust_link(struct net_device *ndev)
                                MVNETA_GMAC_FORCE_LINK_DOWN);
                        mvreg_write(pp, MVNETA_GMAC_AUTONEG_CONFIG, val);
                        mvneta_port_up(pp);
-                       netdev_info(pp->dev, "link up\n");
                } else {
                        mvneta_port_down(pp);
-                       netdev_info(pp->dev, "link down\n");
                }
+               phy_print_status(phydev);
        }
 }