OSDN Git Service

ASoC: amd: pcm-dma: Fix signedness bug in acp_pdm_audio_probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 4 Mar 2022 13:13:35 +0000 (16:13 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 7 Mar 2022 13:14:48 +0000 (13:14 +0000)
The "adata->pdm_irq" variable is unsigned so the error handling will
not work.

Fixes: 87d71a128771 ("ASoC: amd: pcm-dma: Use platform_get_irq() to get the interrupt")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220304131335.GB28739@kili
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/renoir/acp3x-pdm-dma.c

index 88a2425..8c42345 100644 (file)
@@ -399,9 +399,10 @@ static int acp_pdm_audio_probe(struct platform_device *pdev)
        if (!adata->acp_base)
                return -ENOMEM;
 
-       adata->pdm_irq = platform_get_irq(pdev, 0);
-       if (adata->pdm_irq < 0)
-               return -ENODEV;
+       status = platform_get_irq(pdev, 0);
+       if (status < 0)
+               return status;
+       adata->pdm_irq = status;
 
        adata->capture_stream = NULL;