OSDN Git Service

ice: trivial: fix odd indenting
authorJesse Brandeburg <jesse.brandeburg@intel.com>
Tue, 21 Dec 2021 23:05:38 +0000 (15:05 -0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 22 Dec 2021 22:57:55 +0000 (14:57 -0800)
Fix an odd indent where some code was left indented, and causes smatch
to warn:
ice_log_pkg_init() warn: inconsistent indenting

While here, for consistency, add a break after the default case.

This commit has a Fixes: but we caught this while it was only in net-next.

Fixes: 247dd97d713c ("ice: Refactor status flow for DDP load")
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Link: https://lore.kernel.org/r/20211221230538.2546315-1-jesse.brandeburg@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/ice/ice_main.c

index ed0322f..476533f 100644 (file)
@@ -4126,13 +4126,14 @@ static void ice_log_pkg_init(struct ice_hw *hw, enum ice_ddp_state state)
                break;
        case ICE_DDP_PKG_LOAD_ERROR:
                dev_err(dev, "An error occurred on the device while loading the DDP package.  The device will be reset.\n");
-                       /* poll for reset to complete */
-                       if (ice_check_reset(hw))
-                               dev_err(dev, "Error resetting device. Please reload the driver\n");
+               /* poll for reset to complete */
+               if (ice_check_reset(hw))
+                       dev_err(dev, "Error resetting device. Please reload the driver\n");
                break;
        case ICE_DDP_PKG_ERR:
        default:
                dev_err(dev, "An unknown error occurred when loading the DDP package.  Entering Safe Mode.\n");
+               break;
        }
 }