OSDN Git Service

Revert "Revert "Re-enable one thread dumping the native stack of another.""
authorAndreas Gampe <agampe@google.com>
Fri, 27 Feb 2015 21:35:39 +0000 (13:35 -0800)
committerAndreas Gampe <agampe@google.com>
Sat, 28 Feb 2015 04:12:47 +0000 (20:12 -0800)
This reverts commit edfdaf37d5520a3c3a858b6b3fba4f759c60dadc.

Tests seem to succeed. Might be helpful to understand some deadlock/timeout
situations.

Bug: 15446488
Bug: 18713034
Change-Id: I5be225363f698556221576b5827d9501e26799f3

runtime/utils.cc

index 6afc373..fd2f110 100644 (file)
@@ -1264,14 +1264,6 @@ void DumpNativeStack(std::ostream& os, pid_t tid, const char* prefix,
     return;
   }
 
-#if !defined(HAVE_ANDROID_OS)
-  if (GetTid() != tid) {
-    // TODO: dumping of other threads is disabled to avoid crashes during stress testing.
-    //       b/15446488.
-    return;
-  }
-#endif
-
   std::unique_ptr<Backtrace> backtrace(Backtrace::Create(BACKTRACE_CURRENT_PROCESS, tid));
   if (!backtrace->Unwind(0, reinterpret_cast<ucontext*>(ucontext_ptr))) {
     os << prefix << "(backtrace::Unwind failed for thread " << tid << ")\n";