OSDN Git Service

alpha: kernel: using memcpy() instead of strcpy()
authorChen Gang <gang.chen@asianux.com>
Wed, 29 May 2013 10:51:28 +0000 (18:51 +0800)
committerMatt Turner <mattst88@gmail.com>
Fri, 19 Jul 2013 20:54:14 +0000 (13:54 -0700)
When sending message in send_secondary_console_msg(), the length is not
include the NUL byte, and also not copy NUL to 'ipc_buffer'.

When receive message in recv_secondary_console_msg(), the 'cnt' also
excludes NUL.

So when get string from ipc_buffer, it may not be NUL terminated.

Then use memcpy() instead of strcpy(), and set last byte NUL.

Reviewed-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Matt Turner <mattst88@gmail.com>
Signed-off-by: Chen Gang <gang.chen@asianux.com>
arch/alpha/kernel/smp.c

index 53b18a6..4bc3c41 100644 (file)
@@ -266,7 +266,8 @@ recv_secondary_console_msg(void)
                else {
                        cp1 = (char *) &cpu->ipc_buffer[11];
                        cp2 = buf;
-                       strcpy(cp2, cp1);
+                       memcpy(cp2, cp1, cnt);
+                       cp2[cnt] = '\0';
                        
                        while ((cp2 = strchr(cp2, '\r')) != 0) {
                                *cp2 = ' ';