* choose-temp.c (choose_temp_base): Check the result of the call

	to mktemp rather than testing the length of the modified string.

diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog
index e72f845..49afc15 100644 (file)
--- a/libiberty/ChangeLog
+++ b/libiberty/ChangeLog
@@ -1,3 +1,8 @@
+2007-01-12  Ben Elliston  <bje@au.ibm.com>
+
+       * choose-temp.c (choose_temp_base): Check the result of the call
+       to mktemp rather than testing the length of the modified string.
+       
 2006-12-20  Geoffrey Keating  <geoffk@apple.com>
 
        * cp-demangle.h: Add comment explaining what to do to avoid

diff --git a/libiberty/choose-temp.c b/libiberty/choose-temp.c
index 0cba990..4a26a82 100644 (file)
--- a/libiberty/choose-temp.c
+++ b/libiberty/choose-temp.c
@@ -65,8 +65,7 @@ choose_temp_base (void)
   strcpy (temp_filename, base);
   strcpy (temp_filename + len, TEMP_FILE);
 
-  mktemp (temp_filename);
-  if (strlen (temp_filename) == 0)
+  if (mktemp (temp_filename) == 0)
     abort ();
   return temp_filename;
 }