OSDN Git Service

soundwire: intel: remove .trigger callback implementation
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Mon, 15 May 2023 07:10:39 +0000 (15:10 +0800)
committerVinod Koul <vkoul@kernel.org>
Sat, 27 May 2023 10:36:47 +0000 (16:06 +0530)
The interface is not needed for IPC3 solutions but will be needed
with an updated parameter list for ACE2.x+IPC4 combinations.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20230515071042.2038-24-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/intel.c

index c8eb1ec..15cecd2 100644 (file)
@@ -872,18 +872,9 @@ static int intel_trigger(struct snd_pcm_substream *substream, int cmd, struct sn
 {
        struct sdw_cdns *cdns = snd_soc_dai_get_drvdata(dai);
        struct sdw_intel *sdw = cdns_to_intel(cdns);
-       struct sdw_intel_link_res *res = sdw->link_res;
        struct sdw_cdns_dai_runtime *dai_runtime;
        int ret = 0;
 
-       /*
-        * The .trigger callback is used to send required IPC to audio
-        * firmware. The .free_stream callback will still be called
-        * by intel_free_stream() in the TRIGGER_SUSPEND case.
-        */
-       if (res->ops && res->ops->trigger)
-               res->ops->trigger(dai, cmd, substream->stream);
-
        dai_runtime = cdns->dai_runtime_array[dai->id];
        if (!dai_runtime) {
                dev_err(dai->dev, "failed to get dai runtime in %s\n",