OSDN Git Service

ALSA: ps3: Use WARN_ON() instead of BUG_ON()
authorTakashi Iwai <tiwai@suse.de>
Tue, 5 Nov 2013 14:01:47 +0000 (15:01 +0100)
committerTakashi Iwai <tiwai@suse.de>
Wed, 6 Nov 2013 07:34:58 +0000 (08:34 +0100)
BUG_ON() is rather useless for debugging as it leads to panic().
Use WARN_ON() and handle the error cases accordingly.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/ppc/snd_ps3.c

index 8c7dcbe..ebb76f2 100644 (file)
@@ -933,8 +933,10 @@ static int snd_ps3_driver_probe(struct ps3_system_bus_device *dev)
        int i, ret;
        u64 lpar_addr, lpar_size;
 
-       BUG_ON(!firmware_has_feature(FW_FEATURE_PS3_LV1));
-       BUG_ON(dev->match_id != PS3_MATCH_ID_SOUND);
+       if (WARN_ON(!firmware_has_feature(FW_FEATURE_PS3_LV1)))
+               return -ENODEV;
+       if (WARN_ON(dev->match_id != PS3_MATCH_ID_SOUND))
+               return -ENODEV;
 
        the_card.ps3_dev = dev;