OSDN Git Service

ARM: dts: lpc32xx: ea3250: beautify gpio keys children nodes
authorVladimir Zapolskiy <vz@mleia.com>
Tue, 29 Jan 2019 19:20:47 +0000 (21:20 +0200)
committerVladimir Zapolskiy <vz@mleia.com>
Sun, 3 Feb 2019 19:37:43 +0000 (21:37 +0200)
Regarding the 'gpio_keys' device node a dtc reports a couple of
warnings:

  Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary
  #address-cells/#size-cells without "ranges" or child "reg" property

  Warning (unit_address_vs_reg): /gpio_keys/button@21: node has
  a unit name, but no reg property

The change fixes these issues and adds empty lines between adjacent
children device nodes. The device node itself is renamed by substituting
an underscore by hyphen to follow the standard naming convention
of device tree nodes.

Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
arch/arm/boot/dts/lpc3250-ea3250.dts

index ef6b3e7..f46a118 100644 (file)
                reg = <0x80000000 0x4000000>;
        };
 
-       gpio_keys {
+       gpio-keys {
                compatible = "gpio-keys";
-               #address-cells = <1>;
-               #size-cells = <0>;
                autorepeat;
-               button@21 {
+
+               button {
                        label = "Interrupt Key";
                        linux,code = <103>;
                        gpios = <&gpio 4 1 0>; /* GPI_P3 1 */
                };
+
                key1 {
                        label = "KEY1";
                        linux,code = <1>;
                        gpios = <&pca9532 0 0>;
                };
+
                key2 {
                        label = "KEY2";
                        linux,code = <2>;
                        gpios = <&pca9532 1 0>;
                };
+
                key3 {
                        label = "KEY3";
                        linux,code = <3>;
                        gpios = <&pca9532 2 0>;
                };
+
                key4 {
                        label = "KEY4";
                        linux,code = <4>;
                        gpios = <&pca9532 3 0>;
                };
+
                joy0 {
                        label = "Joystick Key 0";
                        linux,code = <10>;
                        gpios = <&gpio 2 0 0>; /* P2.0 */
                };
+
                joy1 {
                        label = "Joystick Key 1";
                        linux,code = <11>;
                        gpios = <&gpio 2 1 0>; /* P2.1 */
                };
+
                joy2 {
                        label = "Joystick Key 2";
                        linux,code = <12>;
                        gpios = <&gpio 2 2 0>; /* P2.2 */
                };
+
                joy3 {
                        label = "Joystick Key 3";
                        linux,code = <13>;
                        gpios = <&gpio 2 3 0>; /* P2.3 */
                };
+
                joy4 {
                        label = "Joystick Key 4";
                        linux,code = <14>;