OSDN Git Service

drm/i915: debugfs/i915_gem_seqno_info does not need rpm nor struct_mutex
authorChris Wilson <chris@chris-wilson.co.uk>
Sat, 3 Sep 2016 06:53:42 +0000 (07:53 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Sat, 3 Sep 2016 12:10:26 +0000 (13:10 +0100)
i915_gem_seqno_info() supplies its own spinlocks to access the waiters,
and doesn't need any GGTT or mmio access.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: http://patchwork.freedesktop.org/patch/msgid/20160903065343.25151-1-chris@chris-wilson.co.uk
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
drivers/gpu/drm/i915/i915_debugfs.c

index 7be8321..3590f1f 100644 (file)
@@ -714,21 +714,11 @@ static void i915_ring_seqno_info(struct seq_file *m,
 static int i915_gem_seqno_info(struct seq_file *m, void *data)
 {
        struct drm_i915_private *dev_priv = node_to_i915(m->private);
-       struct drm_device *dev = &dev_priv->drm;
        struct intel_engine_cs *engine;
-       int ret;
-
-       ret = mutex_lock_interruptible(&dev->struct_mutex);
-       if (ret)
-               return ret;
-       intel_runtime_pm_get(dev_priv);
 
        for_each_engine(engine, dev_priv)
                i915_ring_seqno_info(m, engine);
 
-       intel_runtime_pm_put(dev_priv);
-       mutex_unlock(&dev->struct_mutex);
-
        return 0;
 }