OSDN Git Service

btrfs: ref-verify: Remove unused parameter from walk_up_tree() to kill warning
authorGeert Uytterhoeven <geert@linux-m68k.org>
Wed, 15 Nov 2017 15:04:40 +0000 (16:04 +0100)
committerDavid Sterba <dsterba@suse.com>
Mon, 22 Jan 2018 15:08:13 +0000 (16:08 +0100)
With gcc-4.1.2:

    fs/btrfs/ref-verify.c: In function ‘btrfs_build_ref_tree’:
    fs/btrfs/ref-verify.c:1017: warning: ‘root’ is used uninitialized in this function

The variable is indeed passed uninitialized, but it is never used by the
callee.  However, not all versions of gcc are smart enough to notice.

Hence remove the unused parameter from walk_up_tree() to silence the
compiler warning.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/ref-verify.c

index 3487869..171f3cc 100644 (file)
@@ -606,8 +606,7 @@ static int walk_down_tree(struct btrfs_root *root, struct btrfs_path *path,
 }
 
 /* Walk up to the next node that needs to be processed */
-static int walk_up_tree(struct btrfs_root *root, struct btrfs_path *path,
-                       int *level)
+static int walk_up_tree(struct btrfs_path *path, int *level)
 {
        int l;
 
@@ -984,7 +983,6 @@ void btrfs_free_ref_tree_range(struct btrfs_fs_info *fs_info, u64 start,
 int btrfs_build_ref_tree(struct btrfs_fs_info *fs_info)
 {
        struct btrfs_path *path;
-       struct btrfs_root *root;
        struct extent_buffer *eb;
        u64 bytenr = 0, num_bytes = 0;
        int ret, level;
@@ -1014,7 +1012,7 @@ int btrfs_build_ref_tree(struct btrfs_fs_info *fs_info)
                                     &bytenr, &num_bytes);
                if (ret)
                        break;
-               ret = walk_up_tree(root, path, &level);
+               ret = walk_up_tree(path, &level);
                if (ret < 0)
                        break;
                if (ret > 0) {