OSDN Git Service

staging: unisys: visorbus: get rid of POSTCODES in my_device_changestate
authorDavid Kershner <david.kershner@unisys.com>
Tue, 18 Apr 2017 20:55:20 +0000 (16:55 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Apr 2017 09:51:20 +0000 (11:51 +0200)
Replace POSTCODEs with dev_err in the function my_device_changestate.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorbus/visorchipset.c

index 8b1cca8..6fc8980 100644 (file)
@@ -849,14 +849,10 @@ my_device_changestate(struct controlvm_message *inmsg)
 
        dev_info = visorbus_get_device_by_id(bus_no, dev_no, NULL);
        if (!dev_info) {
-               POSTCODE_LINUX(DEVICE_CHANGESTATE_FAILURE_PC, dev_no, bus_no,
-                              DIAG_SEVERITY_ERR);
                err = -ENODEV;
                goto err_respond;
        }
        if (dev_info->state.created == 0) {
-               POSTCODE_LINUX(DEVICE_CHANGESTATE_FAILURE_PC, dev_no, bus_no,
-                              DIAG_SEVERITY_ERR);
                err = -EINVAL;
                goto err_respond;
        }
@@ -895,6 +891,7 @@ my_device_changestate(struct controlvm_message *inmsg)
        return 0;
 
 err_respond:
+       dev_err(&chipset_dev->acpi_device->dev, "failed: %d\n", err);
        if (inmsg->hdr.flags.response_expected == 1)
                controlvm_responder(inmsg->hdr.id, &inmsg->hdr, err);
        return err;