OSDN Git Service

rtnetlink: fix missing size for IFLA_IF_NETNSID
authorColin Ian King <colin.king@canonical.com>
Mon, 6 Nov 2017 15:04:54 +0000 (15:04 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 8 Nov 2017 04:46:25 +0000 (13:46 +0900)
The size for IFLA_IF_NETNSID is missing from the size calculation
because the proceeding semicolon was not removed. Fix this by removing
the semicolon.

Detected by CoverityScan, CID#1461135 ("Structurally dead code")

Fixes: 79e1ad148c84 ("rtnetlink: use netnsid to query interface")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Jiri Benc <jbenc@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/rtnetlink.c

index dc5ad84..dabba2a 100644 (file)
@@ -920,7 +920,7 @@ static noinline size_t if_nlmsg_size(const struct net_device *dev,
               + rtnl_xdp_size() /* IFLA_XDP */
               + nla_total_size(4)  /* IFLA_EVENT */
               + nla_total_size(4)  /* IFLA_NEW_NETNSID */
-              + nla_total_size(1); /* IFLA_PROTO_DOWN */
+              + nla_total_size(1)  /* IFLA_PROTO_DOWN */
               + nla_total_size(4)  /* IFLA_IF_NETNSID */
               + 0;
 }