OSDN Git Service

autofs: fix a leak in autofs_expire_indirect()
authorAl Viro <viro@zeniv.linux.org.uk>
Fri, 25 Oct 2019 04:03:11 +0000 (00:03 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 25 Oct 2019 04:03:11 +0000 (00:03 -0400)
if the second call of should_expire() in there ends up
grabbing and returning a new reference to dentry, we need
to drop it before continuing.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/autofs/expire.c

index 2866fab..91f5787 100644 (file)
@@ -459,9 +459,10 @@ static struct dentry *autofs_expire_indirect(struct super_block *sb,
                 */
                how &= ~AUTOFS_EXP_LEAVES;
                found = should_expire(expired, mnt, timeout, how);
-               if (!found || found != expired)
-                       /* Something has changed, continue */
+               if (found != expired) { // something has changed, continue
+                       dput(found);
                        goto next;
+               }
 
                if (expired != dentry)
                        dput(dentry);