OSDN Git Service

block/rnbd: Use blk_opf_t where appropriate
authorBart Van Assche <bvanassche@acm.org>
Thu, 14 Jul 2022 18:06:42 +0000 (11:06 -0700)
committerJens Axboe <axboe@kernel.dk>
Thu, 14 Jul 2022 18:14:31 +0000 (12:14 -0600)
Improve static type checking by using the new blk_opf_t type to represent
the combination of a request and request flags.

Acked-by: Jack Wang <jinpu.wang@ionos.com>
Cc: Md. Haris Iqbal <haris.iqbal@ionos.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20220714180729.1065367-17-bvanassche@acm.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/rnbd/rnbd-proto.h

index bfb08dd..ea7ac8b 100644 (file)
@@ -229,9 +229,9 @@ static inline bool rnbd_flags_supported(u32 flags)
        return true;
 }
 
-static inline u32 rnbd_to_bio_flags(u32 rnbd_opf)
+static inline blk_opf_t rnbd_to_bio_flags(u32 rnbd_opf)
 {
-       u32 bio_opf;
+       blk_opf_t bio_opf;
 
        switch (rnbd_op(rnbd_opf)) {
        case RNBD_OP_READ:
@@ -286,7 +286,8 @@ static inline u32 rq_to_rnbd_flags(struct request *rq)
                break;
        default:
                WARN(1, "Unknown request type %d (flags %llu)\n",
-                    req_op(rq), (unsigned long long)rq->cmd_flags);
+                    (__force u32)req_op(rq),
+                    (__force unsigned long long)rq->cmd_flags);
                rnbd_opf = 0;
        }