OSDN Git Service

Fix BitVector::IndexIterator::operator*() to return uint32_t.
authorVladimir Marko <vmarko@google.com>
Fri, 2 Jan 2015 17:00:44 +0000 (17:00 +0000)
committerVladimir Marko <vmarko@google.com>
Fri, 23 Jan 2015 11:35:05 +0000 (11:35 +0000)
Change-Id: I3cfc028b1c3744ec85ea00eadcbccfdde6fd51d3

runtime/base/bit_vector-inl.h
runtime/base/bit_vector.h
runtime/base/bit_vector_test.cc

index dc13dd5..39b19e5 100644 (file)
@@ -29,7 +29,7 @@ inline bool BitVector::IndexIterator::operator==(const IndexIterator& other) con
   return bit_index_ == other.bit_index_;
 }
 
-inline int BitVector::IndexIterator::operator*() const {
+inline uint32_t BitVector::IndexIterator::operator*() const {
   DCHECK_LT(bit_index_, BitSize());
   return bit_index_;
 }
index 1e28a27..557a2ec 100644 (file)
@@ -52,7 +52,7 @@ class BitVector {
       return !(*this == other);
     }
 
-    int operator*() const;
+    uint32_t operator*() const;
 
     IndexIterator& operator++();
 
index 31fd0e7..fe3313d 100644 (file)
@@ -57,10 +57,10 @@ TEST(BitVector, Test) {
 
   BitVector::IndexIterator iterator = bv.Indexes().begin();
   EXPECT_TRUE(iterator != bv.Indexes().end());
-  EXPECT_EQ(0, *iterator);
+  EXPECT_EQ(0u, *iterator);
   ++iterator;
   EXPECT_TRUE(iterator != bv.Indexes().end());
-  EXPECT_EQ(static_cast<int>(kBits - 1), *iterator);
+  EXPECT_EQ(kBits - 1u, *iterator);
   ++iterator;
   EXPECT_TRUE(iterator == bv.Indexes().end());
 }