OSDN Git Service

HID: hid-ntrig: use true and false for boolean values
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 6 Mar 2018 00:06:24 +0000 (18:06 -0600)
committerJiri Kosina <jkosina@suse.cz>
Tue, 6 Mar 2018 14:19:13 +0000 (15:19 +0100)
Assign true or false to boolean variables instead of an integer value.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-ntrig.c

index 3d121d8..43b1c72 100644 (file)
@@ -591,8 +591,8 @@ static int ntrig_event (struct hid_device *hid, struct hid_field *field,
        switch (usage->hid) {
        case 0xff000001:
                /* Tag indicating the start of a multitouch group */
-               nd->reading_mt = 1;
-               nd->first_contact_touch = 0;
+               nd->reading_mt = true;
+               nd->first_contact_touch = false;
                break;
        case HID_DG_TIPSWITCH:
                nd->tipswitch = value;
@@ -663,7 +663,7 @@ static int ntrig_event (struct hid_device *hid, struct hid_field *field,
                         * even if deactivation slack is turned off.
                         */
                        nd->act_state = deactivate_slack - 1;
-                       nd->confidence = 0;
+                       nd->confidence = false;
                        break;
                }
 
@@ -679,7 +679,7 @@ static int ntrig_event (struct hid_device *hid, struct hid_field *field,
                         */
                        if (nd->w < nd->min_width ||
                            nd->h < nd->min_height)
-                               nd->confidence = 0;
+                               nd->confidence = false;
                } else
                        break;
 
@@ -758,7 +758,7 @@ static int ntrig_event (struct hid_device *hid, struct hid_field *field,
                if (!nd->reading_mt) /* Just to be sure */
                        break;
 
-               nd->reading_mt = 0;
+               nd->reading_mt = false;
 
 
                /*
@@ -910,7 +910,7 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id)
                return -ENOMEM;
        }
 
-       nd->reading_mt = 0;
+       nd->reading_mt = false;
        nd->min_width = 0;
        nd->min_height = 0;
        nd->activate_slack = activate_slack;