OSDN Git Service

regulator: core: Fix return code for invalid parameters
authorMark Brown <broonie@linaro.org>
Fri, 20 Sep 2013 11:32:18 +0000 (12:32 +0100)
committerMark Brown <broonie@linaro.org>
Mon, 23 Sep 2013 11:04:13 +0000 (12:04 +0100)
We should be returning an error, a repeated call will never succeed.

Signed-off-by: Mark Brown <broonie@linaro.org>
drivers/regulator/core.c

index 66ae12d..ad15424 100644 (file)
@@ -1288,7 +1288,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
 
        if (id == NULL) {
                pr_err("get() with no identifier\n");
-               return regulator;
+               return ERR_PTR(-EINVAL);
        }
 
        if (dev)