OSDN Git Service

netdevsim: fix uninit value in nsim_drv_configure_vfs()
authorJakub Kicinski <kuba@kernel.org>
Mon, 1 Nov 2021 22:18:45 +0000 (15:18 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 1 Nov 2021 23:29:56 +0000 (16:29 -0700)
Build bot points out that I missed initializing ret
after refactoring.

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 1c401078bcf3 ("netdevsim: move details of vf config to dev")
Link: https://lore.kernel.org/r/20211101221845.3188490-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/netdevsim/dev.c

index 5db40d7..54345c0 100644 (file)
@@ -1723,13 +1723,11 @@ int nsim_drv_configure_vfs(struct nsim_bus_dev *nsim_bus_dev,
                           unsigned int num_vfs)
 {
        struct nsim_dev *nsim_dev = dev_get_drvdata(&nsim_bus_dev->dev);
-       int ret;
+       int ret = 0;
 
        mutex_lock(&nsim_dev->vfs_lock);
-       if (nsim_bus_dev->num_vfs == num_vfs) {
-               ret = 0;
+       if (nsim_bus_dev->num_vfs == num_vfs)
                goto exit_unlock;
-       }
        if (nsim_bus_dev->num_vfs && num_vfs) {
                ret = -EBUSY;
                goto exit_unlock;