OSDN Git Service

r8169: let rtl8169_mark_to_asic clear rx descriptor field opts2
authorHeiner Kallweit <hkallweit1@gmail.com>
Tue, 10 Mar 2020 22:14:41 +0000 (23:14 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 10 Mar 2020 23:23:23 +0000 (16:23 -0700)
Clearing opts2 belongs to preparing the descriptor for DMA engine use.
Therefore move it into rtl8169_mark_to_asic().

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/realtek/r8169_main.c

index 181b35b..c0731c3 100644 (file)
@@ -3889,6 +3889,7 @@ static inline void rtl8169_mark_to_asic(struct RxDesc *desc)
 {
        u32 eor = le32_to_cpu(desc->opts1) & RingEnd;
 
+       desc->opts2 = 0;
        /* Force memory writes to complete before releasing descriptor */
        dma_wmb();
 
@@ -4543,7 +4544,6 @@ process_pkt:
                        u64_stats_update_end(&tp->rx_stats.syncp);
                }
 release_descriptor:
-               desc->opts2 = 0;
                rtl8169_mark_to_asic(desc);
        }