OSDN Git Service

spi: sifive: Remove spi_master_put in sifive_spi_remove()
authorWei Yongjun <weiyongjun1@huawei.com>
Fri, 22 Feb 2019 05:46:16 +0000 (05:46 +0000)
committerMark Brown <broonie@kernel.org>
Fri, 22 Feb 2019 15:17:43 +0000 (15:17 +0000)
The call to spi_master_put() in sifive_spi_remove() is redundant since
the master is registered using devm_spi_register_master() and no
reference hold by using spi_master_get() in sifive_spi_remove().

This is detected by Coccinelle semantic patch.

Fixes: 484a9a68d669 ("spi: sifive: Add driver for the SiFive SPI controller")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-sifive.c

index 961307c..ebca3fc 100644 (file)
@@ -424,7 +424,6 @@ static int sifive_spi_remove(struct platform_device *pdev)
 
        /* Disable all the interrupts just in case */
        sifive_spi_write(spi, SIFIVE_SPI_REG_IE, 0);
-       spi_master_put(master);
 
        return 0;
 }