OSDN Git Service

doc-rst: Delete output of failed dot-SVG conversion
authorBen Hutchings <ben@decadent.org.uk>
Tue, 31 Jan 2017 00:18:44 +0000 (00:18 +0000)
committerJonathan Corbet <corbet@lwn.net>
Mon, 6 Feb 2017 16:03:50 +0000 (09:03 -0700)
As we use redirection to create the SVG file, even a failed conversion
will create the file and 'make' will consider it up-to-date if the
build is retried.  We should delete it in case of failure.

Fixes: ec868e4ee2bc ("docs-rst: media: build SVG from graphviz files")
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
Documentation/media/Makefile

index 3266360..730d73d 100644 (file)
@@ -36,7 +36,7 @@ quiet_cmd_genpdf = GENPDF  $2
       cmd_genpdf = convert $2 $3
 
 quiet_cmd_gendot = DOT     $2
-      cmd_gendot = dot -Tsvg $2 > $3
+      cmd_gendot = dot -Tsvg $2 > $3 || { rm -f $3; exit 1; }
 
 %.pdf: %.svg
        @$(call cmd,genpdf,$<,$@)