OSDN Git Service

ice: Simplify memory allocation in ice_sched_init_port()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 4 Sep 2022 14:22:46 +0000 (16:22 +0200)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 6 Sep 2022 20:55:47 +0000 (13:55 -0700)
'buf' is locale to the ice_sched_init_port() function.
There is no point in using devm_kzalloc()/devm_kfree().

use kzalloc()/kfree() instead.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_sched.c

index 7947223..1185957 100644 (file)
@@ -1212,7 +1212,7 @@ int ice_sched_init_port(struct ice_port_info *pi)
        hw = pi->hw;
 
        /* Query the Default Topology from FW */
-       buf = devm_kzalloc(ice_hw_to_dev(hw), ICE_AQ_MAX_BUF_LEN, GFP_KERNEL);
+       buf = kzalloc(ICE_AQ_MAX_BUF_LEN, GFP_KERNEL);
        if (!buf)
                return -ENOMEM;
 
@@ -1290,7 +1290,7 @@ err_init_port:
                pi->root = NULL;
        }
 
-       devm_kfree(ice_hw_to_dev(hw), buf);
+       kfree(buf);
        return status;
 }