OSDN Git Service

avoid temporary in QFile::readLineData()
authorIvailo Monev <xakepa10@gmail.com>
Fri, 6 Nov 2020 14:47:39 +0000 (16:47 +0200)
committerIvailo Monev <xakepa10@gmail.com>
Fri, 6 Nov 2020 14:47:39 +0000 (16:47 +0200)
Signed-off-by: Ivailo Monev <xakepa10@gmail.com>
src/core/io/qfile.cpp

index 45f14d3..5beeb8a 100644 (file)
@@ -1311,16 +1311,12 @@ qint64 QFile::readLineData(char *data, qint64 maxlen)
     if (!d->ensureFlushed())
         return -1;
 
-    qint64 read;
     if (d->fileEngine->supportsExtension(QAbstractFileEngine::FastReadLineExtension)) {
-        read = d->fileEngine->readLine(data, maxlen);
-    } else {
-        // Fall back to QIODevice's readLine implementation if the engine
-        // cannot do it faster.
-        read = QIODevice::readLineData(data, maxlen);
+        return d->fileEngine->readLine(data, maxlen);
     }
-
-    return read;
+    // Fall back to QIODevice's readLine implementation if the engine
+    // cannot do it faster.
+    return QIODevice::readLineData(data, maxlen);
 }
 
 /*!