OSDN Git Service

net: xenbus: remove redundant condition check before debugfs_remove_recursive
authorzhong jiang <zhongjiang@huawei.com>
Sat, 8 Sep 2018 13:35:06 +0000 (21:35 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 12 Sep 2018 06:01:33 +0000 (23:01 -0700)
debugfs_remove_recursive has taken the IS_ERR_OR_NULL into account. Just
remove the unnecessary condition check.

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/xen-netback/xenbus.c

index cd51492..fe1d522 100644 (file)
@@ -254,8 +254,7 @@ static void xenvif_debugfs_delif(struct xenvif *vif)
        if (IS_ERR_OR_NULL(xen_netback_dbg_root))
                return;
 
-       if (!IS_ERR_OR_NULL(vif->xenvif_dbg_root))
-               debugfs_remove_recursive(vif->xenvif_dbg_root);
+       debugfs_remove_recursive(vif->xenvif_dbg_root);
        vif->xenvif_dbg_root = NULL;
 }
 #endif /* CONFIG_DEBUG_FS */