OSDN Git Service

Merge branch 'patch-2' of https://github.com/zzet/gitlabhq into zzet-patch-2
authorDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Thu, 26 Sep 2013 19:19:01 +0000 (22:19 +0300)
committerDmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
Thu, 26 Sep 2013 19:19:01 +0000 (22:19 +0300)
Conflicts:
app/controllers/projects/merge_requests_controller.rb

1  2 
app/controllers/projects/merge_requests_controller.rb

@@@ -157,12 -122,16 +157,15 @@@ class Projects::MergeRequestsControlle
    end
  
    def validates_merge_request
-     # Show git not found page if target branch doesn't exist
-     return invalid_mr unless @merge_request.target_project.repository.branch_names.include?(@merge_request.target_branch)
-     # Show git not found page if source branch doesn't exist
-     # and there is no saved commits between source & target branch
-     return invalid_mr if !@merge_request.source_project.repository.branch_names.include?(@merge_request.source_branch) && @merge_request.commits.blank?
+     # Show git not found page
+     # if there is no saved commits between source & target branch
+     if @merge_request.commits.blank?
 -       # and
 -       # if source target doesn't exist
 -       return invalid_mr if !@project.repository.branch_names.include?(@merge_request.target_branch)
++       # and if source target doesn't exist
++       return invalid_mr unless @merge_request.target_project.repository.branch_names.include?(@merge_request.target_branch)
+        # or if source branch doesn't exist
 -       return invalid_mr if !@project.repository.branch_names.include?(@merge_request.source_branch)
++       return invalid_mr unless @merge_request.source_project.repository.branch_names.include?(@merge_request.source_branch)
+     end
    end
  
    def define_show_vars