OSDN Git Service

staging: lustre: llite: fix ifnullfree.cocci warnings
authorkbuild test robot <fengguang.wu@intel.com>
Thu, 30 Apr 2015 16:21:55 +0000 (00:21 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Apr 2015 20:27:38 +0000 (22:27 +0200)
drivers/staging/lustre/lustre/llite/llite_lib.c:989:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.
drivers/staging/lustre/lustre/llite/llite_lib.c:991:2-7: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

 NULL check before some freeing functions is not needed.

 Based on checkpatch warning
 "kfree(NULL) is safe this check is probably not required"
 and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/llite/llite_lib.c

index f44abb6..e5bac94 100644 (file)
@@ -985,10 +985,8 @@ int ll_fill_super(struct super_block *sb, struct vfsmount *mnt)
        err = client_common_fill_super(sb, md, dt, mnt);
 
 out_free:
-       if (md)
-               kfree(md);
-       if (dt)
-               kfree(dt);
+       kfree(md);
+       kfree(dt);
        if (err)
                ll_put_super(sb);
        else if (sbi->ll_flags & LL_SBI_VERBOSE)