OSDN Git Service

phy: amlogic: phy-meson-gxl-usb2: default to host mode
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Sun, 28 Jan 2018 20:22:43 +0000 (21:22 +0100)
committerKishon Vijay Abraham I <kishon@ti.com>
Thu, 8 Mar 2018 08:26:28 +0000 (13:56 +0530)
The USB2 PHY can switch between PHY_MODE_USB_HOST and
PHY_MODE_USB_DEVICE. However, it cannot do it on it's own since it
requires re-routing of the corresponding USB pins from dwc3 (which is
used for host-mode) to dwc2 (which is used for device-mode).
Thus we don't need to auto-detect the mode based on the USB controller,
which simplifies the driver code.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/amlogic/Kconfig
drivers/phy/amlogic/phy-meson-gxl-usb2.c

index cb8f450..ef3625c 100644 (file)
@@ -18,7 +18,6 @@ config PHY_MESON_GXL_USB2
        default ARCH_MESON
        depends on OF && (ARCH_MESON || COMPILE_TEST)
        depends on USB_SUPPORT
-       select USB_COMMON
        select GENERIC_PHY
        select REGMAP_MMIO
        help
index a92a3fd..f062fc7 100644 (file)
@@ -20,7 +20,6 @@
 #include <linux/reset.h>
 #include <linux/phy/phy.h>
 #include <linux/platform_device.h>
-#include <linux/usb/of.h>
 
 /* bits [31:27] are read-only */
 #define U2P_R0                                                 0x0
@@ -254,18 +253,8 @@ static int phy_meson_gxl_usb2_probe(struct platform_device *pdev)
        if (IS_ERR(base))
                return PTR_ERR(base);
 
-       switch (of_usb_get_dr_mode_by_phy(dev->of_node, -1)) {
-       case USB_DR_MODE_PERIPHERAL:
-               priv->mode = PHY_MODE_USB_DEVICE;
-               break;
-       case USB_DR_MODE_OTG:
-               priv->mode = PHY_MODE_USB_OTG;
-               break;
-       case USB_DR_MODE_HOST:
-       default:
-               priv->mode = PHY_MODE_USB_HOST;
-               break;
-       }
+       /* start in host mode */
+       priv->mode = PHY_MODE_USB_HOST;
 
        priv->regmap = devm_regmap_init_mmio(dev, base,
                                             &phy_meson_gxl_usb2_regmap_conf);