ath10k: fix tx status flag setting for management frames

The tx_status for management frames is being filled
incorrectly in the flags of skb_cb. This incorrect
flag setting causes the upper layers to consider that
the particular frame was not transmitted properly,
leading to improper behavior.

Set the IEEE80211_TX_STAT_ACK flag in the info flags
of skb_cb, to indicate the successful transmission of
the management frame.

Tested HW: WCN3990
Tested FW: WLAN.HL.2.0-01188-QCAHLSWMTPLZ-1

Fixes: dc405152bb64d4ae01c9ac669de25b2d1fb6fc2d
Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index 8093d94..c1a46af 100644 (file)
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -2342,7 +2342,12 @@ static int wmi_process_mgmt_tx_comp(struct ath10k *ar, u32 desc_id,
        dma_unmap_single(ar->dev, pkt_addr->paddr,
                         msdu->len, DMA_FROM_DEVICE);
        info = IEEE80211_SKB_CB(msdu);
-       info->flags |= status;
+
+       if (status)
+               info->flags &= ~IEEE80211_TX_STAT_ACK;
+       else
+               info->flags |= IEEE80211_TX_STAT_ACK;
+
        ieee80211_tx_status_irqsafe(ar->hw, msdu);
 
        ret = 0;