OSDN Git Service

epoll: simplify ep_alloc()
authorZhen Lei <thunder.leizhen@huawei.com>
Wed, 26 Jul 2023 03:21:35 +0000 (11:21 +0800)
committerChristian Brauner <brauner@kernel.org>
Wed, 26 Jul 2023 12:56:07 +0000 (14:56 +0200)
The get_current_user() does not fail, and moving it after kzalloc() can
simplify the code a bit.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Message-Id: <20230726032135.933-1-thunder.leizhen@huaweicloud.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/eventpoll.c

index 4b1b336..1d9a71a 100644 (file)
@@ -975,15 +975,11 @@ again:
 
 static int ep_alloc(struct eventpoll **pep)
 {
-       int error;
-       struct user_struct *user;
        struct eventpoll *ep;
 
-       user = get_current_user();
-       error = -ENOMEM;
        ep = kzalloc(sizeof(*ep), GFP_KERNEL);
        if (unlikely(!ep))
-               goto free_uid;
+               return -ENOMEM;
 
        mutex_init(&ep->mtx);
        rwlock_init(&ep->lock);
@@ -992,16 +988,12 @@ static int ep_alloc(struct eventpoll **pep)
        INIT_LIST_HEAD(&ep->rdllist);
        ep->rbr = RB_ROOT_CACHED;
        ep->ovflist = EP_UNACTIVE_PTR;
-       ep->user = user;
+       ep->user = get_current_user();
        refcount_set(&ep->refcount, 1);
 
        *pep = ep;
 
        return 0;
-
-free_uid:
-       free_uid(user);
-       return error;
 }
 
 /*