OSDN Git Service

at76c50x-usb: avoid double usb_put_dev() after downloading internal firmware in at76_...
authorAlexey Khoroshilov <khoroshilov@ispras.ru>
Sat, 20 Feb 2016 22:30:29 +0000 (01:30 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Mon, 7 Mar 2016 12:24:06 +0000 (14:24 +0200)
There is no need in usb_put_dev() if at76_load_internal_fw() succeed.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/atmel/at76c50x-usb.c

index dab2513..1efb1d6 100644 (file)
@@ -2481,9 +2481,7 @@ static int at76_probe(struct usb_interface *interface,
                        dev_err(&interface->dev,
                                "error %d downloading internal firmware\n",
                                ret);
-                       goto exit;
                }
-               usb_put_dev(udev);
                goto exit;
        }