OSDN Git Service

drm/vgem: Remove unecessary dma_fence_ops
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 9 Aug 2018 12:45:44 +0000 (14:45 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 17 Aug 2018 09:22:58 +0000 (11:22 +0200)
dma_fence_default_wait is the default now, same for the trivial
enable_signaling implementation.

Also remove the ->signaled callback, vgem can't peek ahead with a
fastpath, returning false is the default implementation.

v2: Protect the meaningful space! (Chris)

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Kees Cook <keescook@chromium.org>
Cc: Cihangir Akturk <cakturk@gmail.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20180809124544.9250-1-daniel.vetter@ffwll.ch
drivers/gpu/drm/vgem/vgem_fence.c

index b28876c..e6ee713 100644 (file)
@@ -43,16 +43,6 @@ static const char *vgem_fence_get_timeline_name(struct dma_fence *fence)
        return "unbound";
 }
 
-static bool vgem_fence_signaled(struct dma_fence *fence)
-{
-       return false;
-}
-
-static bool vgem_fence_enable_signaling(struct dma_fence *fence)
-{
-       return true;
-}
-
 static void vgem_fence_release(struct dma_fence *base)
 {
        struct vgem_fence *fence = container_of(base, typeof(*fence), base);
@@ -76,9 +66,6 @@ static void vgem_fence_timeline_value_str(struct dma_fence *fence, char *str,
 static const struct dma_fence_ops vgem_fence_ops = {
        .get_driver_name = vgem_fence_get_driver_name,
        .get_timeline_name = vgem_fence_get_timeline_name,
-       .enable_signaling = vgem_fence_enable_signaling,
-       .signaled = vgem_fence_signaled,
-       .wait = dma_fence_default_wait,
        .release = vgem_fence_release,
 
        .fence_value_str = vgem_fence_value_str,