OSDN Git Service

staging: vt6656: Fixed multiple logical comparisions warnings
authorParth Sane <laerdevstudios@gmail.com>
Tue, 22 Mar 2016 12:55:37 +0000 (18:25 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Mar 2016 14:30:36 +0000 (07:30 -0700)
Using comparison to false and true is error prone. Fixed multiple warnings as
per checkpatch guidelines.

Signed-off-by: Parth Sane <laerdevstudios@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6656/wcmd.c

index 4846a89..95faaeb 100644 (file)
@@ -97,7 +97,7 @@ void vnt_run_command(struct work_struct *work)
        if (test_bit(DEVICE_FLAGS_DISCONNECTED, &priv->flags))
                return;
 
-       if (priv->cmd_running != true)
+       if (!priv->cmd_running)
                return;
 
        switch (priv->command_state) {
@@ -143,13 +143,13 @@ void vnt_run_command(struct work_struct *work)
 
                if (priv->rx_antenna_sel == 0) {
                        priv->rx_antenna_sel = 1;
-                       if (priv->tx_rx_ant_inv == true)
+                       if (priv->tx_rx_ant_inv)
                                vnt_set_antenna_mode(priv, ANT_RXA);
                        else
                                vnt_set_antenna_mode(priv, ANT_RXB);
                } else {
                        priv->rx_antenna_sel = 0;
-                       if (priv->tx_rx_ant_inv == true)
+                       if (priv->tx_rx_ant_inv)
                                vnt_set_antenna_mode(priv, ANT_RXB);
                        else
                                vnt_set_antenna_mode(priv, ANT_RXA);
@@ -174,7 +174,7 @@ int vnt_schedule_command(struct vnt_private *priv, enum vnt_cmd command)
        ADD_ONE_WITH_WRAP_AROUND(priv->cmd_enqueue_idx, CMD_Q_SIZE);
        priv->free_cmd_queue--;
 
-       if (priv->cmd_running == false)
+       if (!priv->cmd_running)
                vnt_cmd_complete(priv);
 
        return true;