OSDN Git Service

iwlwifi: dbg_ini: allocate dram buffer with proper flags
authorShahar S Matityahu <shahar.s.matityahu@intel.com>
Mon, 26 Nov 2018 09:19:00 +0000 (11:19 +0200)
committerLuca Coelho <luciano.coelho@intel.com>
Tue, 29 Jan 2019 14:10:33 +0000 (16:10 +0200)
Use the same flags we use in the legacy buffer allocation.
Missing __GFP_NOWARN will cause an unwanted warning incase
we fail to allocate.
Missing __GFP_ZERO will give a buffer initially filled with
garbage which can make debug difficult in case our wrap count is zero.

Signed-off-by: Shahar S Matityahu <shahar.s.matityahu@intel.com>
Fixes: d47902f9f71d ("iwlwifi: dbg: add apply point logic")
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/fw/dbg.c

index 917aafe..947f282 100644 (file)
@@ -1697,8 +1697,10 @@ iwl_fw_dbg_buffer_allocation(struct iwl_fw_runtime *fwrt,
            IWL_FW_INI_LOCATION_DRAM_PATH)
                return;
 
-       virtual_addr = dma_alloc_coherent(fwrt->trans->dev, size,
-                                         &phys_addr, GFP_KERNEL);
+       virtual_addr =
+               dma_alloc_coherent(fwrt->trans->dev, size, &phys_addr,
+                                  GFP_KERNEL | __GFP_NOWARN | __GFP_ZERO |
+                                  __GFP_COMP);
 
        /* TODO: alloc fragments if needed */
        if (!virtual_addr)