OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
184f6eb
)
ieee1394: fix broken signed char assumption.
author
Linus Torvalds
<torvalds@g5.osdl.org>
Wed, 6 Jul 2005 20:05:50 +0000
(13:05 -0700)
committer
Linus Torvalds
<torvalds@g5.osdl.org>
Wed, 6 Jul 2005 20:05:50 +0000
(13:05 -0700)
"ack_code" is assigned (and tested against) negative numbers, but was
declared as "char". Which only works if "char" is signed - which it
necessarily isn't.
So make that signedness assumption specific.
drivers/ieee1394/ieee1394_core.h
patch
|
blob
|
history
diff --git
a/drivers/ieee1394/ieee1394_core.h
b/drivers/ieee1394/ieee1394_core.h
index
73bd8ef
..
0b31429
100644
(file)
--- a/
drivers/ieee1394/ieee1394_core.h
+++ b/
drivers/ieee1394/ieee1394_core.h
@@
-38,8
+38,8
@@
struct hpsb_packet {
/* These are core internal. */
signed char tlabel;
- char ack_code;
- char tcode;
+
signed
char ack_code;
+
unsigned
char tcode;
unsigned expect_response:1;
unsigned no_waiter:1;