OSDN Git Service

pinctrl: actions: make s900_functions, s900_padinfo and s900_pads static
authorColin Ian King <colin.king@canonical.com>
Mon, 30 Apr 2018 13:04:34 +0000 (14:04 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 2 May 2018 12:36:31 +0000 (14:36 +0200)
s900_functions, s900_padinfo and s900_pads are local to the source and do
not need to be in global scope, so make them static.

Cleans up sparse warnings:
drivers/pinctrl/actions/pinctrl-s900.c:1445:30: warning: symbol
's900_functions' was not declared. Should it be static?
drivers/pinctrl/actions/pinctrl-s900.c:1664:20: warning: symbol
's900_padinfo' was not declared. Should it be static?
drivers/pinctrl/actions/pinctrl-s900.c:207:31: warning: symbol
's900_pads' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/actions/pinctrl-s900.c

index 49a04e2..08d93f8 100644 (file)
 #define NUM_PADS               (_PIN(3) + 1)
 
 /* Pad names as specified in datasheet */
-const struct pinctrl_pin_desc s900_pads[] = {
+static const struct pinctrl_pin_desc s900_pads[] = {
        PINCTRL_PIN(ETH_TXD0, "eth_txd0"),
        PINCTRL_PIN(ETH_TXD1, "eth_txd1"),
        PINCTRL_PIN(ETH_TXEN, "eth_txen"),
@@ -1442,7 +1442,7 @@ static const char * const sirq2_groups[] = {
                .ngroups = ARRAY_SIZE(fname##_groups),  \
        }
 
-const struct owl_pinmux_func s900_functions[] = {
+static const struct owl_pinmux_func s900_functions[] = {
        [S900_MUX_ERAM] = FUNCTION(eram),
        [S900_MUX_ETH_RMII] = FUNCTION(eth_rmii),
        [S900_MUX_ETH_SMII] = FUNCTION(eth_smii),
@@ -1661,7 +1661,7 @@ static PAD_ST_CONF(I2S_MCLK0, 1, 0, 1);
        }
 
 /* Pad info table */
-struct owl_padinfo s900_padinfo[NUM_PADS] = {
+static struct owl_padinfo s900_padinfo[NUM_PADS] = {
        [ETH_TXD0] = PAD_INFO_ST(ETH_TXD0),
        [ETH_TXD1] = PAD_INFO_ST(ETH_TXD1),
        [ETH_TXEN] = PAD_INFO_ST(ETH_TXEN),