OSDN Git Service

ALSA: hda/tegra: remove redundant clock enable API
authorSameer Pujar <spujar@nvidia.com>
Tue, 22 Jan 2019 07:33:19 +0000 (13:03 +0530)
committerTakashi Iwai <tiwai@suse.de>
Tue, 22 Jan 2019 08:21:55 +0000 (09:21 +0100)
Explicit clock enable is not required during probe, as this would be
managed by runtime PM calls. Clock can be enabled/disabled in runtime
resume/suspend. This way it is easier to balance clock enable/disable
counts.

Signed-off-by: Sameer Pujar <spujar@nvidia.com>
Reviewed-by: Ravindra Lokhande <rlokhande@nvidia.com>
Reviewed-by: Mohan Kumar D <mkumard@nvidia.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_tegra.c

index 1189f97..f068b1e 100644 (file)
@@ -319,7 +319,6 @@ static int hda_tegra_init_chip(struct azx *chip, struct platform_device *pdev)
        struct hdac_bus *bus = azx_bus(chip);
        struct device *dev = hda->dev;
        struct resource *res;
-       int err;
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        hda->regs = devm_ioremap_resource(dev, res);
@@ -329,12 +328,6 @@ static int hda_tegra_init_chip(struct azx *chip, struct platform_device *pdev)
        bus->remap_addr = hda->regs + HDA_BAR0;
        bus->addr = res->start + HDA_BAR0;
 
-       err = hda_tegra_enable_clocks(hda);
-       if (err) {
-               dev_err(dev, "failed to get enable clocks\n");
-               return err;
-       }
-
        hda_tegra_init(hda);
 
        return 0;