OSDN Git Service

ASoC: codecs: wm0010: use DECLARE_COMPLETION_ONSTACK() macro
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thu, 13 Aug 2020 17:54:42 +0000 (12:54 -0500)
committerMark Brown <broonie@kernel.org>
Tue, 18 Aug 2020 13:52:41 +0000 (14:52 +0100)
Follow recommendation in Documentation/scheduler/completion.rst and
use macro to declare local 'struct completion'

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20200813175442.59067-1-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm0010.c

index 2f2b2f5..28b4656 100644 (file)
@@ -346,7 +346,7 @@ static int wm0010_firmware_load(const char *name, struct snd_soc_component *comp
        struct list_head xfer_list;
        struct wm0010_boot_xfer *xfer;
        int ret;
-       struct completion done;
+       DECLARE_COMPLETION_ONSTACK(done);
        const struct firmware *fw;
        const struct dfw_binrec *rec;
        const struct dfw_inforec *inforec;
@@ -370,7 +370,6 @@ static int wm0010_firmware_load(const char *name, struct snd_soc_component *comp
        wm0010->boot_failed = false;
        if (WARN_ON(!list_empty(&xfer_list)))
                return -EINVAL;
-       init_completion(&done);
 
        /* First record should be INFO */
        if (rec->command != DFW_CMD_INFO) {